----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review177687 -----------------------------------------------------------
Can you split this review into multiple logical reviews? It is really hard to review otherwise. Below are a few splits I could think of 1) Renames of variables (e.g., in tests). 2) Changes of resources value in tests (not sure of the reason for this change). 3) Addition of a new helper `recoverSlaveState` 4) Changes to containerizers to short circuit recovery if state is none (not sure of the reason for this change) 5) Adding `rebooted` field to recovery info and state (you can combine this with 6th if you want but might be easier to review separately) 6) Keeping the agent id on reboot In addition to making it easy to review it will help us to ship parts of this chain sooner than later. - Vinod Kone On June 9, 2017, 4:27 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56895/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 4:27 a.m.) > > > Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6223 > https://issues.apache.org/jira/browse/MESOS-6223 > > > Repository: mesos > > > Description > ------- > > With partition awareness, the agents are now allowed to re-register > after they have been marked Unreachable. The executors are anyway > terminated on the agent when it reboots so there is no harm in > letting the agent keep its SlaveID, re-register with the master > and reconcile the lost executors. This is a pre-requisite for > supporting persistent/restartable tasks in mesos. > > > Diffs > ----- > > src/slave/containerizer/composing.cpp > a003e1b80dc9b4dec5b3fbbadb2daecf855c90c7 > src/slave/containerizer/docker.cpp 9f84109d7de22a39ace6e44e0c7d8d501bcb24de > src/slave/containerizer/mesos/containerizer.cpp > f3e6210eccd4a6b445ffd4447e69526d424ea36d > src/slave/slave.hpp 7ffaed14035a05259ec72c70532ee4f0affa1f5d > src/slave/slave.cpp 7d147ac6609933ac884bfc29032dba572a0952c6 > src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5 > src/slave/state.cpp 18b790d2cc4f537cc9b0c3cca59b9cbaac0eda10 > src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f > src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c > > > Diff: https://reviews.apache.org/r/56895/diff/7/ > > > Testing > ------- > > make check > > > Thanks, > > Megha Sharma > >
