> On June 12, 2017, 11:41 p.m., Zhitao Li wrote: > > It seems that majority of this patch is generated code. Is the `.proto` > > change the only real code change? If so, should we write some c++ test code > > to use the map based fields and json parsing of map? > > > > Also, explaining which files are generated in summary will help reviewers > > to know what changes we can safekly skip reading?
Yes, the `.proto` change is the only real code changed, I have updated the description to mention that. And for the test, please refer to https://reviews.apache.org/r/59989/. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59988/#review177626 ----------------------------------------------------------- On June 13, 2017, 4:41 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59988/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 4:41 p.m.) > > > Review request for mesos, Anand Mazumdar and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > The real code changes is adding `MapMessage` to protobuf_tests.proto, > for the other two files in this patch, they are automatically generated > by running protobuf-3.3.0 compiler `protoc` on protobuf_tests.proto. > > > Diffs > ----- > > 3rdparty/stout/tests/protobuf_tests.pb.h > 2e4ffe17a07ce2360ec618e936ae4557e9dc8e62 > 3rdparty/stout/tests/protobuf_tests.pb.cc > ad6eff779d1cc0e7d037ea77565533c3ebb0b2d6 > 3rdparty/stout/tests/protobuf_tests.proto > d16726aa8060aea2b830040b20dbdd467c801483 > > > Diff: https://reviews.apache.org/r/59988/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
