----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60020/#review177849 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/resources.hpp Lines 433-434 (patched) <https://reviews.apache.org/r/60020/#comment251563> Should these return `Try`s? Or is the caller responsible for calling these with a valid reservation and only when there is a reservation to pop, respectively? (If not we crash) Would be great to add documentation so it's clear to the caller. src/common/resources.cpp Lines 1368 (patched) <https://reviews.apache.org/r/60020/#comment251562> Is this hard to do? Any reason it was left out? - Benjamin Mahler On June 13, 2017, 8:36 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60020/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 8:36 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > Added pushReservation and popReservation. > > > Diffs > ----- > > include/mesos/resources.hpp 451b0cef6f84743e3d630104ba6f55665793f2bc > include/mesos/v1/resources.hpp c790927353122a4eb2bbbee31c6df57d97f3994b > src/common/resources.cpp f89f1aae7845f1e93dd5947de2e7a8e2bfce8bc4 > src/v1/resources.cpp 24240eedc4b2747ca02998534437318c3396db4d > > > Diff: https://reviews.apache.org/r/60020/diff/2/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
