-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60124/#review178030
-----------------------------------------------------------




src/examples/balloon_framework.cpp
Line 464 (original), 469 (patched)
<https://reviews.apache.org/r/60124/#comment251798>

    Consistency wise, other tests have just `executor.set_name("Framework Name 
Executor (C++)");` to set the name of the executor (e.g. in 
`long_lived_framework.cpp`). More generally, what is the reason to add a `name` 
flag for this test?


- Armand Grillet


On June 15, 2017, 5:09 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60124/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 5:09 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp bfaae3796afb426459ef5cff3a37634a8242032e 
> 
> 
> Diff: https://reviews.apache.org/r/60124/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to