----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review178068 -----------------------------------------------------------
src/common/http.hpp Lines 168-170 (patched) <https://reviews.apache.org/r/60107/#comment251869> Maybe something like: "Used to filter which objects will be returned when building responses for requests to the operator APIs." src/common/http.hpp Lines 178 (patched) <https://reviews.apache.org/r/60107/#comment251870> End all comments with a period. src/common/http.hpp Lines 198 (patched) <https://reviews.apache.org/r/60107/#comment251867> Indent two more spaces. src/common/http.cpp Lines 1136 (patched) <https://reviews.apache.org/r/60107/#comment251871> This will fail if `authorizer.isNone()` is true. Should do: ``` if (authorizer.isNone()) { return AcceptingFilter(); } else { // construct/return AuthorizeTaskInfoFilter here... } ``` This will allow us to factor out all of the checks for `authorizer.isSome()` in the handler code, which is nice. src/common/http.cpp Lines 1139-1140 (patched) <https://reviews.apache.org/r/60107/#comment251866> Indent two more spaces. - Greg Mann On June 15, 2017, 11:57 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60107/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 11:57 p.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7630 > https://issues.apache.org/jira/browse/MESOS-7630 > > > Repository: mesos > > > Description > ------- > > Add class definition for ObjectFilter. > > > Diffs > ----- > > src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e > src/common/http.cpp 167dce2b9a2d3b68a1df5b4079f701482d34db28 > > > Diff: https://reviews.apache.org/r/60107/diff/2/ > > > Testing > ------- > > Passed "make check" > No specific test case related > > > Thanks, > > Quinn Leng > >
