----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review178133 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto Lines 349 (patched) <https://reviews.apache.org/r/59861/#comment251971> "The framework is offered resources in a new format." include/mesos/mesos.proto Lines 359 (patched) <https://reviews.apache.org/r/59861/#comment251968> "The framework can create refined reservations." include/mesos/mesos.proto Lines 368 (patched) <https://reviews.apache.org/r/59861/#comment251964> Typo: "capability" Tweak: "A resource is said to have" include/mesos/mesos.proto Lines 980 (patched) <https://reviews.apache.org/r/59861/#comment251965> Is this consistent with the "set both old and new fields for endpoints" approach? include/mesos/mesos.proto Lines 1005 (patched) <https://reviews.apache.org/r/59861/#comment251966> "a framework or agent"? Seems technically correct but maybe confusing to mention here. include/mesos/mesos.proto Lines 1101 (patched) <https://reviews.apache.org/r/59861/#comment251970> Can we add a note here that the contents of the `reservations` field are ordered from "least refined" to "most refined"? include/mesos/v1/mesos.proto Lines 367 (patched) <https://reviews.apache.org/r/59861/#comment251967> Typo include/mesos/v1/mesos.proto Lines 1151 (patched) <https://reviews.apache.org/r/59861/#comment251969> Remove comma: "reservation's role," - Neil Conway On June 16, 2017, 10:51 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59861/ > ----------------------------------------------------------- > > (Updated June 16, 2017, 10:51 p.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7575 > https://issues.apache.org/jira/browse/MESOS-7575 > > > Repository: mesos > > > Description > ------- > > With reservation refinement, we now represent the reservation state in > \`Resource.reservations\` rather than with \`Resource.role\` and > \`Resource.reservation\`. We also keep track of the type of reservation, > and the role the reservation is for in the \`Resource.ReservationInfo\`. > This patch introduces these changes and explains the different formats > in detail. > > > Diffs > ----- > > include/mesos/mesos.proto e9a8b1513150b394f4986a1f34483cfca32b35e3 > include/mesos/v1/mesos.proto 5e8c15c07a02999e3376d2104c1c642f00511969 > src/common/protobuf_utils.hpp 7b1a1289c16edde44143432b645ecc2222e68576 > src/common/protobuf_utils.cpp 46331b379c732edc597b46bb10665c95c9640e96 > > > Diff: https://reviews.apache.org/r/59861/diff/12/ > > > Testing > ------- > > Updated tests + `make check` > > > Thanks, > > Michael Park > >
