----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59454/#review178163 -----------------------------------------------------------
Ship it! lgtm, although I'll change the commit message -- there isn't anything specific about GCC 7.1 in this fix. - Neil Conway On May 24, 2017, 5:53 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59454/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 5:53 p.m.) > > > Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and > Neil Conway. > > > Bugs: MESOS-7520 > https://issues.apache.org/jira/browse/MESOS-7520 > > > Repository: mesos > > > Description > ------- > > This fixes tests that uses the old inheritance types from `bytes.hpp`. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp ef0085316 > src/tests/role_tests.cpp 03b6f7bd6 > > > Diff: https://reviews.apache.org/r/59454/diff/3/ > > > Testing > ------- > > `./bootstrap && mkdir build && cd build && ../configure --disable-python > --disable-java --disable-optimize --disable-hardening && make check > -j$(nproc)` > > > Thanks, > > Aaron Wood > >
