----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60040/#review178181 -----------------------------------------------------------
src/common/resources.cpp Line 683 (original), 693 (patched) <https://reviews.apache.org/r/60040/#comment252050> Can we clarify that the return value of this function is always (?) going to be validated by the caller, so it is okay to use the pre-refinement format here? src/common/resources.cpp Line 687 (original), 697 (patched) <https://reviews.apache.org/r/60040/#comment252051> btw, the fact that `Resources::fromString` is called separately (e.g., by containerizer) makes me a little nervous, because the caller of `fromString` needs to ensure they validate/convert the resource appropriately. I guess that was always the case though. src/v1/resources.cpp Lines 663 (patched) <https://reviews.apache.org/r/60040/#comment252053> Should the `!resource.has_reservation()` be a `CHECK` instead? src/v1/resources.cpp Lines 672 (patched) <https://reviews.apache.org/r/60040/#comment252052> `CopyFrom`, I'd think. - Neil Conway On June 13, 2017, 8:42 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60040/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 8:42 a.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/resources.cpp cc305e64cadc9fab913ede987625fc1839646306 > src/v1/resources.cpp 03d6c8098a24a2751617d14f2664de1d88318414 > > > Diff: https://reviews.apache.org/r/60040/diff/4/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
