----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60017/#review178182 -----------------------------------------------------------
src/common/resources.cpp Line 1551 (original), 1556 (patched) <https://reviews.apache.org/r/60017/#comment252054> We should be careful about the user experience here: the error message ("Resource must be dynamically reserved") might be interpreted as saying the resource is statically reserved, not that it is unreserved. I'd prefer two separate checks with different error messages, for `Resources::isReserved` and `Resources::isDynamicallyReserved`. src/common/resources_utils.cpp Line 56 (original), 56 (patched) <https://reviews.apache.org/r/60017/#comment252055> I'm confused. Seems like this is a behavioral change for reservation refinements, not a change to just adapt to the new format? In any case, seems like a comment would be helpful. - Neil Conway On June 13, 2017, 8:35 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60017/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 8:35 a.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/resources.cpp cc305e64cadc9fab913ede987625fc1839646306 > src/common/resources_utils.cpp aca2a0c630164af718007c70197461cebcd10d3e > src/v1/resources.cpp 03d6c8098a24a2751617d14f2664de1d88318414 > > > Diff: https://reviews.apache.org/r/60017/diff/5/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
