-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/#review178357
-----------------------------------------------------------
I think this does not work as is since we would e.g., still reject commits
where the commit summary is longer than 72 chars, e.g., the following commit
summary should be considered formally okay,
fixup fixup squash
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA.
One way to achieve that would be to e.g., treat the length check of the summary
line separately from the description, but maybe you have a better idea.
- Benjamin Bannier
On June 20, 2017, 1:18 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60216/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 1:18 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4331
> https://issues.apache.org/jira/browse/MESOS-4331
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The capitalization check caused rebases to fail for commits made with
> `--fixup` and `--squash`. This change ignores the check for these cases.
>
>
> Diffs
> -----
>
> support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca
>
>
> Diff: https://reviews.apache.org/r/60216/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
