----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60227/#review178374 -----------------------------------------------------------
support/mesos-style.py Line 90 (original), 115 (patched) <https://reviews.apache.org/r/60227/#comment252304> Why can't we simply use if not regex.search(head): here? support/mesos-style.py Line 194 (original), 218 (patched) <https://reviews.apache.org/r/60227/#comment252305> Since we now wrap this, could we have a single alternative per line to make this actually readable? I'd also prefer simple line continutations with `\` instead of the `(x) == x` (the LHS looks like a list but actually isn't), e.g., exclude_files = '(' 'protobuf-2.4.1|' \' 'googletest-release-1.8.0|' \ ... support/mesos-style.py Line 251 (original), 278 (patched) <https://reviews.apache.org/r/60227/#comment252306> Ditto. - Benjamin Bannier On June 20, 2017, 12:13 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60227/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 12:13 p.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Bugs: MESOS-6390 > https://issues.apache.org/jira/browse/MESOS-6390 > > > Repository: mesos > > > Description > ------- > > This will allow us to use PyLint on the > entire support directory in the future. > > > Diffs > ----- > > support/mesos-style.py f9c852806bfb2ead1552b5da4aa337edc5b9f947 > > > Diff: https://reviews.apache.org/r/60227/diff/1/ > > > Testing > ------- > > Added `support` to `source_dirs` in the PyLinter defined > in `mesos-style.py`. Linted until only acceptable errors > where displayed (e.g. due to the name of the file containing > a dash instead of an underscore). > > > Thanks, > > Armand Grillet > >
