----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60253/ -----------------------------------------------------------
(Updated June 20, 2017, 5:47 p.m.) Review request for mesos and Neil Conway. Repository: mesos Description ------- `Resources` requires that the `Resource` objects being constructed with be validated and are in the "post-reservation-refinement" format. The `convertResourceFormat` was previously placed after the validation of operations, but we construct `Resources` prior to operation validation. This patch moves the conversion logic earlier to be done right after resource validation. Diffs ----- src/master/http.cpp 801b80933985a95d58f6b3b9973558d0c5a4410e Diff: https://reviews.apache.org/r/60253/diff/2/ Testing ------- ```bash curl -i -d slaveId=9091bf1d-58cb-4f54-b804-fe3eef85facd-S0 -d resources='[{"name":"cpus","type":"SCALAR","scalar":{"value":1},"role":"ads","reservation":{}},{"name":"mem","type":"SCALAR","scalar":{"value":1024},"role":"ads","reservation":{}}]' -X POST http://127.0.0.1:5050/master/reserve ``` Thanks, Michael Park