----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60283/ -----------------------------------------------------------
Review request for mesos and Neil Conway. Repository: mesos Description ------- Initially, it seemed like calling `convertResourceFormat` after operation validation seemed safe since the operation validation themselves performed `Resources::validate` within them. However, the rest of the operation validation code relies on the fact that the resources have been validated, and uses functions such as `isDynamicallyReserved`. Since functions such as `isDynamicallyReserved` now requires "post-reservation-refinement" format, we must perform this conversion earlier. In this patch, we use `upgradeResources` to perform resources validation __and__ convert the resources before going into the operation and task validation. We really need a better plan for this going forward. MESOS-7702. Diffs ----- src/master/master.cpp ec594a8f4fa95e77fc38103c5561d1797fe2b133 Diff: https://reviews.apache.org/r/60283/diff/1/ Testing ------- Thanks, Michael Park
