----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59464/#review178543 -----------------------------------------------------------
Ship it! LGTM. I can add the comment mentioned below before committing. src/slave/containerizer/fetcher.hpp Lines 327-328 (patched) <https://reviews.apache.org/r/59464/#comment252597> It's important enough to add a comment here about the counter resolution. This number will go up once per task, rather than once per artifact. So if 1 task asks for 10 artifacts, the total number of fetches is 1. If 1 to 10 of those artifacts fail to fetch, the total number of failures is also 1. src/slave/containerizer/fetcher.cpp Lines 68-78 (original), 70-78 (patched) <https://reviews.apache.org/r/59464/#comment252596> This change isn't strictly related to the metrics, so it could be moved elsewhere. - Joseph Wu On June 9, 2017, 11:55 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59464/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 11:55 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-7524 > https://issues.apache.org/jira/browse/MESOS-7524 > > > Repository: mesos > > > Description > ------- > > Add the Fetcher metrics to track the number of fetch requests > sent to the Fetcher (`containerizer/fetcher/task_fetches_total`) > and the number of errors reported by the Fetcher > (`containerizer/fetcher/task_fetches_failed`). > > > Diffs > ----- > > src/slave/containerizer/fetcher.hpp > efeadbf4b7804ea4c1e443d1e5212e303796ace4 > src/slave/containerizer/fetcher.cpp > 770cad3e046e8a6d58b6bc9176eb7ecdbd340db4 > > > Diff: https://reviews.apache.org/r/59464/diff/4/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
