> On June 21, 2017, 7:28 p.m., Aaron Wood wrote:
> > Someone correct me if I'm wrong, but I don't think we need this anymore:
> > ```
> > if (launchInfo.has_working_directory()) {
> > Try<Nothing> chdir = os::chdir(launchInfo.working_directory());
> > if (chdir.isError()) {
> > cerr << "Failed to chdir into current working directory "
> > << "'" << launchInfo.working_directory() << "': "
> > << chdir.error() << endl;
> > exitWithStatus(EXIT_FAILURE);
> > }
> > }
> > ```
> > Everyone okay with me removing this?
No, we cannot. We do want the process's cwd to be inside the sandbox.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60280/#review178534
-----------------------------------------------------------
On June 21, 2017, 7:15 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60280/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 7:15 p.m.)
>
>
> Review request for mesos, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-7703
> https://issues.apache.org/jira/browse/MESOS-7703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a framework specifies use of its own executor and sets shell to false the
> executor is never found. Additionally, the name of the binary is never passed
> as an argument so executors making use of argv[0] will fail. This provides
> the full path to the executor so that the `execvp` or `execvpe` is
> successful. The name of the binary is also passed as the first argument for
> cases where there is no shell used.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp 162ca1c2e
>
>
> Diff: https://reviews.apache.org/r/60280/diff/1/
>
>
> Testing
> -------
>
> `cd build && cmake .. -DCMAKE_BUILD_TYPE=Release && make -j4`
> Also spun up a master and agent, connected and sent a task using the UCR
> (both with and without the use of an OCI image) via our own framework, and
> checked the sandbox to verify that things went accordingly.
>
>
> Thanks,
>
> Aaron Wood
>
>
