----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60230/#review178596 -----------------------------------------------------------
Ship it! I can fix this up before committing. support/jsonurl.py Lines 37 (patched) <https://reviews.apache.org/r/60230/#comment252690> This comment doesn't seem right... support/jsonurl.py Line 13 (original), 38 (patched) <https://reviews.apache.org/r/60230/#comment252689> Since we're fixing these files up, might as well add a guard to this array access: ``` if len(sys.argv) < 2: print >> sys.stderr, "USAGE: {} URL [KEY...]".format(sys.argv[0]) sys.exit(1) ``` - Joseph Wu On June 20, 2017, 3:14 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60230/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 3:14 a.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Bugs: MESOS-6390 > https://issues.apache.org/jira/browse/MESOS-6390 > > > Repository: mesos > > > Description > ------- > > This will allow us to use PyLint on the > entire support directory in the future. > > > Diffs > ----- > > support/jsonurl.py 72a91046c055831d469dde33b54d99a1b4170aef > > > Diff: https://reviews.apache.org/r/60230/diff/1/ > > > Testing > ------- > > Added `support` to `source_dirs` in the PyLinter defined > in `mesos-style.py`. Linted until only acceptable errors > where displayed (e.g. due to the name of the file containing > a dash instead of an underscore). > > > Thanks, > > Armand Grillet > >
