> On June 21, 2017, 4:39 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5798-5867 (original), 5798-5867 (patched) > > <https://reviews.apache.org/r/60105/diff/3/?file=1752079#file1752079line5798> > > > > So all of this work is only useful for recovering frameworks, it looks > > like we don't need to do them before we decide we actually are going to > > recover the frameworks (i.e., not continue as a new agent)? > > > > This reasoning certainly also applies to the current HEAD but since we > > are donig refactor here, we should probably address this (in a separate > > preceding review perhaps)
I strongly agree we should defer doing this work until we start to recover the frameworks. I was thinking of doing this may be as another review for slave recovery improvements after this change is in. - Megha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178388 ----------------------------------------------------------- On June 21, 2017, 11:22 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60105/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 11:22 p.m.) > > > Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6223 > https://issues.apache.org/jira/browse/MESOS-6223 > > > Repository: mesos > > > Description > ------- > > Prior to Mesos 1.4 we bypass the state recovery and > start as a new agent upon reboot. Starting in Mesos 1.4 > we'll attempt to recover the slave state even after reboot > except for when there is a SlaveInfo mismatch. > Here, we cleanup the slave state for a rebooted agent if > there's been a SlaveInfo mismatch during recovery to > ensure that no other state is recovered and the > agent enventually registers as a new agent. > > > Diffs > ----- > > src/slave/slave.cpp f808458849bb9667a91abe18868751d377d36e0c > > > Diff: https://reviews.apache.org/r/60105/diff/5/ > > > Testing > ------- > > Latest make check results pending. > > > Thanks, > > Megha Sharma > >
