----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60232/#review178600 -----------------------------------------------------------
Fix it, then Ship it! I'll fixup before committing. support/mesos-split.py Lines 41-45 (patched) <https://reviews.apache.org/r/60232/#comment252702> It would make more sense to all-CAPS these variables and keep them where they were. Otherwise, we'll be re-initializing them for every single filename. support/mesos-split.py Lines 59-61 (patched) <https://reviews.apache.org/r/60232/#comment252700> Instead of explaining why we have a main method, it would be better to mention what it does, or what it expects. For example: ``` Expects a list of filenames on the command line. See `support/hooks/pre-commit` for the canonical usage of this method. ``` - Joseph Wu On June 20, 2017, 3:15 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60232/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 3:15 a.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Bugs: MESOS-6390 > https://issues.apache.org/jira/browse/MESOS-6390 > > > Repository: mesos > > > Description > ------- > > This will allow us to use PyLint on the > entire support directory in the future. > > > Diffs > ----- > > support/mesos-split.py 92084f15d125a4b4fb2369c385a74999efdf982c > > > Diff: https://reviews.apache.org/r/60232/diff/1/ > > > Testing > ------- > > Added `support` to `source_dirs` in the PyLinter defined > in `mesos-style.py`. Linted until only acceptable errors > where displayed (e.g. due to the name of the file containing > a dash instead of an underscore). > > > Thanks, > > Armand Grillet > >
