----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60279/#review178605 -----------------------------------------------------------
include/mesos/authorizer/authorizer.hpp Lines 74 (patched) <https://reviews.apache.org/r/60279/#comment252713> We would prefer to accept these parameters by const reference, not as pointers. Also, for function parameters we use leading underscores instead of trailing underscores, like `_machine_id`. So the constructors should look like: `Object(const MachineID& _machine_id)` - Greg Mann On June 21, 2017, 6:35 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60279/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 6:35 p.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7630 > https://issues.apache.org/jira/browse/MESOS-7630 > > > Repository: mesos > > > Description > ------- > > Add constructor for ObjectApprover::Object. > > Add constructors for ObjectApprover::Object, making the caller side cleaner. > Only one case is ignored, it's in "src/slave/slave.cpp:6709", since it's > setting parameters after the construction. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 95cbcf3f9a962a896c9c23e961f02eb16dff36f8 > src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 > src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 > src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c > > > Diff: https://reviews.apache.org/r/60279/diff/1/ > > > Testing > ------- > > Passed "make check -j48" > No specific test case related. > > > Thanks, > > Quinn Leng > >
