-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60398/#review178822
-----------------------------------------------------------



This drops the test that verifies we can actually parse perf versions that are 
found in the wild. That test is necessary to catch when new systems play games 
with the perf version; otherwise we would just detect that the perf version 
isn't supported and it would be hard to diagnose why not.

- James Peach


On June 23, 2017, 8:16 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60398/
> -----------------------------------------------------------
> 
> (Updated June 23, 2017, 8:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Split perf version test into 2 separate tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/perf_tests.cpp 
> d8aab08eb131f974821fb85662cbc6cc685d2f3e 
> 
> 
> Diff: https://reviews.apache.org/r/60398/diff/1/
> 
> 
> Testing
> -------
> 
> 1. make check (mac os x 10.12, fedora 25)
> 2. internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Reply via email to