----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/#review178826 -----------------------------------------------------------
Ship it! Great idea! What do you think about setting the core rlimit to 0 in the the `subprocess` clone lambda in `perf::execute()`? - James Peach On June 23, 2017, 8:16 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60397/ > ----------------------------------------------------------- > > (Updated June 23, 2017, 8:16 p.m.) > > > Review request for mesos, Benjamin Bannier, James Peach, and Neil Conway. > > > Bugs: MESOS-7160 > https://issues.apache.org/jira/browse/MESOS-7160 > > > Repository: mesos > > > Description > ------- > > For autotools build, the docker-build script performs a 'distcheck' > build. This type of build warns if any unexpected files are left in > the build directory after an uninstall, mainly to detect broken > uninstall Makefile rules. The return status of the build container is > the result of the distcheck. > This fixes an issue where in some dockerized configurations > invocations of 'perf' segfaulted (producing a core file as a > side-effect), where the failure case was already anticipated and > handled by the caller. > > > Diffs > ----- > > src/tests/environment.cpp a7262cd97361b55ff31238341657e764df6c9ea5 > > > Diff: https://reviews.apache.org/r/60397/diff/1/ > > > Testing > ------- > > 1. make check (mac os x 10.12, fedora 25) > 2. internal CI > > Needs to be confirmed by Apache CI, e.g., reviewbot. > > > Thanks, > > Andrei Budnik > >
