----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60407/ -----------------------------------------------------------
(Updated June 24, 2017, 7:28 p.m.) Review request for mesos, Adam B and Michael Park. Changes ------- Add comments / TODOs. Repository: mesos Description ------- When validating the agent's ReregisterSlaveMessage, the master's validation code neglected to account for the fact that the task resources might not be in post-refinement format (e.g., if the agent does not support reservation refinement). This lead to a `CHECK` failure during validation. Fix this by relaxing the validation of ReregisterSlaveMessage so that we do not depend on the task resources being in post-refinement format. This means validation of ReregisterSlaveMessage will be less effective, but since it is best-effort anyway, this seems tolerable. Diffs (updated) ----- src/master/validation.cpp 33e9ff7db9e2789cbb2d6dfd015288dfa1faa7c5 Diff: https://reviews.apache.org/r/60407/diff/3/ Changes: https://reviews.apache.org/r/60407/diff/2-3/ Testing ------- `make check` Thanks, Neil Conway
