-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60008/#review179176
-----------------------------------------------------------
Bad patch!
Reviews applied: [60008]
Failed command: python support/apply-reviews.py -n -r 60008
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 417, in <module>
main()
File "support/apply-reviews.py", line 412, in main
reviewboard(options)
File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console
- Mesos Reviewbot Windows
On June 28, 2017, 2:56 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60008/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 2:56 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-5886
> https://issues.apache.org/jira/browse/MESOS-5886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FUTURE_DISPATCH uses DispatchMatcher to figure out whether a processed
> DispatchEvent is the same the user is waiting for. Currently, we
> compare std::type_info of function pointers, which is not enough:
> different class methods with same signatures will be matched (see
> MESOS-5886 for an example).
> This patch adds value of pointer-to-member function in addition to
> std::type_info in DispatchEvent to uniquely identify class methods.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/dispatch.hpp
> 3a0793888dc0df5e3ec31b06f47cd920c71e0db9
> 3rdparty/libprocess/include/process/event.hpp
> 8afe6266eb0dc5a17af35d79efb6bfdf9e6a0ee9
> 3rdparty/libprocess/include/process/gmock.hpp
> e9af943b39436f365fe687301febb5c7fbefffc4
> 3rdparty/libprocess/src/process.cpp
> 8ff37d1b5781c42f96be2da391ed000158eea7b8
> 3rdparty/libprocess/src/tests/process_tests.cpp
> 38d787a083a5eb31e922d283f4b4bed2bd62eb0a
>
>
> Diff: https://reviews.apache.org/r/60008/diff/2/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. internal CI
>
> NOTE: Test GroupTest.ConnectTimer is broken, because it uses FUTURE_DISPATCH
> on a wrong method (GroupProcess::expired),
> which has the same signature as a private method (GroupProcess::timedout).
> The later method is actually called,
> thus causing the error after applying this patch.
>
>
> Thanks,
>
> Andrei Budnik
>
>
