----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60564/#review179399 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 3955-3978 (patched) <https://reviews.apache.org/r/60564/#comment254079> I find these nested `switch` statements (with `default` cases) pretty hard to read. What about pulling below `for` loop into a lambda, and calling it from explicit cases for `LAUNCH` or `LAUNCHGROUP` instead. - Benjamin Bannier On June 30, 2017, 11:02 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60564/ > ----------------------------------------------------------- > > (Updated June 30, 2017, 11:02 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7735 > https://issues.apache.org/jira/browse/MESOS-7735 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp 276b18e4d1bab7e9b28c1c93fe13c93a38abc5cd > src/tests/master_tests.cpp cfb799fd105e9880cd56415b2a84e604c8f62703 > > > Diff: https://reviews.apache.org/r/60564/diff/1/ > > > Testing > ------- > > Added a new test + `make check` > > > Thanks, > > Michael Park > >
