-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60641/
-----------------------------------------------------------
(Updated July 6, 2017, 6:36 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rebased.
Summary (updated)
-----------------
Allowed to pass total resources in 'UpdateSlaveMessage'.
Bugs: MESOS-7757
https://issues.apache.org/jira/browse/MESOS-7757
Repository: mesos
Description (updated)
-------
This commit both extends the existing 'UpdateSlaveMessage' proto
message, and adjusts its handling on the agent and master side.
To distinguish updates to 'oversubscribed_resources' from updates to
'total_resources' the message now contains a 'type' field to allow
disambiguation among an empty list of resources and an unset list of
resources. For backwards-compatibility we assume whenever the type
field was not set that caller intended to use the
'oversubscribed_resources' field as opposed to the 'total_resources'
field.
Currently, passing 'total_resources' is handled neither in the master
nor the default allocator; we will implement this in a subsequent
patch.
Diffs (updated)
-----
src/master/master.hpp 9dd6a530c373516dc81bfd51ee6e95f25588148f
src/master/master.cpp 95e9691b3e3ef101e3e7ddc7a498d5c5bf2276e3
src/messages/messages.proto 67cee3146a45f8f720b4e60739cf85085d18259b
src/slave/slave.cpp 0e24b8cb8d1020af515e3d1862e121e1daf82ce9
src/tests/oversubscription_tests.cpp 2266510091b49c61310a363ab6644708655787dc
Diff: https://reviews.apache.org/r/60641/diff/2/
Changes: https://reviews.apache.org/r/60641/diff/1-2/
Testing
-------
Thanks,
Benjamin Bannier
