----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60002/#review179822 -----------------------------------------------------------
Fix it, then Ship it! Happy to ship this, but see comment below. 3rdparty/stout/include/stout/preprocessor.hpp Lines 37 (patched) <https://reviews.apache.org/r/60002/#comment254679> Why make this specific to "templates" and instead just do: ``` #define ENUM BOOST_PP_ENUM ``` - Benjamin Hindman On June 15, 2017, 7:32 a.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60002/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 7:32 a.m.) > > > Review request for mesos, Benjamin Hindman, haosdent huang, James Peach, and > Michael Park. > > > Bugs: MESOS-7713 > https://issues.apache.org/jira/browse/MESOS-7713 > > > Repository: mesos > > > Description > ------- > > Added ENUM_TEMPLATE_PARAMS preprocessor macro. > > This allows using templates to generate parameters lists, for example: > #define MOVE_TEMPLATE(Z, N, DATA) std::move(DATA ## N) > > Then it can be used as > call(ENUM_TEMPLATE_PARAMS(2, MOVE_TEMPLATE, p)); > which is expanded as > call(std::move(p1), std::move(p2)); > > > Diffs > ----- > > 3rdparty/stout/include/stout/preprocessor.hpp > 48d63318712d454b118db64af11c694da92bca6a > > > Diff: https://reviews.apache.org/r/60002/diff/1/ > > > Testing > ------- > > > Thanks, > > Dmitry Zhuk > >