> On July 7, 2017, 11:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 1191 (original), 1192 (patched) > > <https://reviews.apache.org/r/60720/diff/1/?file=1771682#file1771682line1192> > > > > Should `advertise_ip` be treated the same way as `ip`? i.e., flag > > validation and choice between reassignment and modification.
Once we move to the pattern of doing `__address__.ip = libprocess_flags->ip.get()` I think handling of `__address__` for `--ip` and `--advertise_ip` will be the same. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60720/#review179958 ----------------------------------------------------------- On July 7, 2017, 10:04 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60720/ > ----------------------------------------------------------- > > (Updated July 7, 2017, 10:04 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-7769 > https://issues.apache.org/jira/browse/MESOS-7769 > > > Repository: mesos > > > Description > ------- > > When we introduced the `__address6__ optional IPv6 storage into > `libprocess` we also introduced a regression because of which the `port` > doesn't get initialized to whatever is specified in the `--port` flag > until the `--ip` flag is specified. > > This change fixes the initialization of the `__address__` in the > absence of the `--ip` flag. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 264298c16199ded4ccbf948f6893f4209c23aed0 > > > Diff: https://reviews.apache.org/r/60720/diff/1/ > > > Testing > ------- > > > Thanks, > > Avinash sridharan > >
