----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/#review180000 -----------------------------------------------------------
Fix it, then Ship it! Some small changes needed - please commit after you addressed Greg and my comments. src/master/http.cpp Lines 403 (patched) <https://reviews.apache.org/r/59525/#comment254992> A JIRA issue with this would be great as it seems a rather valuable update of this feature. src/master/http.cpp Lines 417-418 (patched) <https://reviews.apache.org/r/59525/#comment254999> The more common pattern nowadays for member naming is to use trailing underscores. That way you do not need to disambiguate the constructor arguments - see Gregs comment. Please also note that the above `FullFrameworkWriter` does use this naming schema as well - so let's do the same here for consistency. src/master/http.cpp Lines 2325-2326 (original), 2333-2334 (patched) <https://reviews.apache.org/r/59525/#comment254995> See my comment above. src/master/http.cpp Lines 2348 (patched) <https://reviews.apache.org/r/59525/#comment254996> This actually confused me more than it helped due to the fact that the above "registered slaves" are not commented. I would suggest to either remove this comment or add a similar one to the above block. src/master/http.cpp Lines 2384-2391 (original), 2414-2421 (patched) <https://reviews.apache.org/r/59525/#comment254998> Indeed as Greg comments, let's filter this as well. src/tests/master_tests.cpp Lines 2242-2243 (patched) <https://reviews.apache.org/r/59525/#comment255000> Not sure I understand - there is only a single slave being started below, no? - Till Toenshoff On July 7, 2017, 3:05 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59525/ > ----------------------------------------------------------- > > (Updated July 7, 2017, 3:05 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-7416 > https://issues.apache.org/jira/browse/MESOS-7416 > > > Repository: mesos > > > Description > ------- > > Adds support of the 'VIEW_ROLE' ACL to the results generated by the > '/slaves' as well as the 'GET_AGENTS' API v1 call, '/states' and > '/states-summary'. > > This means that calls to these endpoints and API call which uses > reservations will only show the reserved resources the user making the > requests is allowed to see based on the reservations roles. > > > Diffs > ----- > > src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a > src/master/master.hpp 95c2d0fab32d6b60f29a86037607ff009bd78717 > src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f > > > Diff: https://reviews.apache.org/r/59525/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
