> On July 7, 2017, 1:15 p.m., Alexander Rojas wrote: > > src/linux/perf.cpp > > Lines 245 (patched) > > <https://reviews.apache.org/r/60397/diff/3/?file=1768325#file1768325line245> > > > > In this case, `LOG(ERROR)` is the wrong log level, since you may expect > > in certain cases for the error to occur. > > > > `LOG(INFO)` seems more reasonable. > > Andrei Budnik wrote: > But I see `LOG(ERROR)` below in the code in `supported()`. In addition, > it looks like it's a real issue when perf is broken or isn't installed. If > perf isn't available, then it's the issue that should be fixed, right?
Ok. Fixed. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/#review179868 ----------------------------------------------------------- On July 3, 2017, 10:57 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60397/ > ----------------------------------------------------------- > > (Updated July 3, 2017, 10:57 a.m.) > > > Review request for mesos, Benjamin Bannier, James Peach, and Neil Conway. > > > Bugs: MESOS-7160 > https://issues.apache.org/jira/browse/MESOS-7160 > > > Repository: mesos > > > Description > ------- > > For autotools build, the docker-build script performs a 'distcheck' > build. This type of build warns if any unexpected files are left in > the build directory after an uninstall, mainly to detect broken > uninstall Makefile rules. The return status of the build container is > the result of the distcheck. > This fixes an issue where in some dockerized configurations > invocations of 'perf' segfaulted (producing a core file as a > side-effect), where the failure case was already anticipated and > handled by the caller. > > > Diffs > ----- > > src/linux/perf.cpp b301e25d5cac6488c57e4f983e4867c72368a040 > src/tests/containerizer/perf_tests.cpp > d8aab08eb131f974821fb85662cbc6cc685d2f3e > > > Diff: https://reviews.apache.org/r/60397/diff/4/ > > > Testing > ------- > > 1. make check (mac os x 10.12, fedora 25) > 2. internal CI > > Needs to be confirmed by Apache CI, e.g., reviewbot. > > > Thanks, > > Andrei Budnik > >
