> On July 10, 2017, 2:19 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/subprocess.cpp > > Line 118 (original), 118 (patched) > > <https://reviews.apache.org/r/60598/diff/3/?file=1771136#file1771136line118> > > > > Here and below, we use the macro `EXIT(EXIT_FAILURE)` with a log output > > when doing these kinds of early exits.
`EXIT()` isn't async-signal-safe, so it's not allowed to use them in both cases. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review180034 ----------------------------------------------------------- On July 3, 2017, 2:58 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60598/ > ----------------------------------------------------------- > > (Updated July 3, 2017, 2:58 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin > Mahler, and James Peach. > > > Bugs: MESOS-7160 > https://issues.apache.org/jira/browse/MESOS-7160 > > > Repository: mesos > > > Description > ------- > > Previously, `abort()` was called in `SUPERVISOR` hook when child > process exited with an error code, or `waitpid()` failed, or parent > process exited. All these cases shouldn't lead to abnormal program > termination with coredumps. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess.cpp > 0f1532b294d6d6b1e017468cfde47362f3faa84d > > > Diff: https://reviews.apache.org/r/60598/diff/3/ > > > Testing > ------- > > make check (mac os x, fedora 25) > > > Thanks, > > Andrei Budnik > >
