----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60293/#review179042 -----------------------------------------------------------
Ship it! 3rdparty/stout/include/stout/windows/os.hpp Lines 78-79 (patched) <https://reviews.apache.org/r/60293/#comment253445> This comment seems a bit more confusing than clarifying. I'll reword to: // NOTE: This returns the hostname of the local computer, or the local // node if this computer is part of a cluster. - Joseph Wu On June 21, 2017, 2:53 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60293/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 2:53 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Bugs: MESOS-6817 and MESOS-7548 > https://issues.apache.org/jira/browse/MESOS-6817 > https://issues.apache.org/jira/browse/MESOS-7548 > > > Repository: mesos > > > Description > ------- > > The former can inordinately slow on Windows (about 5 seconds), > whereas the latter is guaranteed to return instantly. > > Because `os::internal::nodename()` and `net::hostname()` implemented the > exact same feature, we just reuse the first in the second. > > > Diffs > ----- > > 3rdparty/stout/include/stout/net.hpp > 425544e1d428b1c65a15221c34c9d29e7dc31f65 > 3rdparty/stout/include/stout/posix/net.hpp > 59463a05a62559cea3964c2b058a2205db24fa9b > 3rdparty/stout/include/stout/windows/net.hpp > 987ab7075fe3c1127cab7e14831ca22030c35e45 > 3rdparty/stout/include/stout/windows/os.hpp > f1722d5e18af97d89c6ca7aaf002fd58cb0d21ae > > > Diff: https://reviews.apache.org/r/60293/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
