----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review180202 -----------------------------------------------------------
src/tests/slave_recovery_tests.cpp Line 2757 (original), 2747 (patched) <https://reviews.apache.org/r/56895/#comment255245> s/slave Info/agent info/ since is this the terminology used (consistently elsewhere) in this test. src/tests/slave_recovery_tests.cpp Lines 2762 (patched) <https://reviews.apache.org/r/56895/#comment255247> This is unintentional? src/tests/slave_recovery_tests.cpp Lines 2762 (patched) <https://reviews.apache.org/r/56895/#comment255289> This line redundant? src/tests/slave_recovery_tests.cpp Line 2652 (original) <https://reviews.apache.org/r/56895/#comment255287> In the case of real reboot with slave info mismatch I think we should receive a task lost for this so why not set the expetation explicitly instead of removing it? src/tests/slave_recovery_tests.cpp Line 2655 (original), 2786 (patched) <https://reviews.apache.org/r/56895/#comment255288> Are there no `master/slave_removals` here? Seems like MESOS-5396 doens't apply here. - Jiang Yan Xu On July 10, 2017, 4:15 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56895/ > ----------------------------------------------------------- > > (Updated July 10, 2017, 4:15 p.m.) > > > Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6223 > https://issues.apache.org/jira/browse/MESOS-6223 > > > Repository: mesos > > > Description > ------- > > Added tests to verify that the state is recovered post reboot and > agentId is retained given the recovery finishes without errors and > if the recovery fails due to slaveInfo mismatch then agent no > state is recoverd making the agent register as a new agent. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp f6eafcbe3d89c7a69c03db0fd7bc10ae73d06584 > > > Diff: https://reviews.apache.org/r/56895/diff/14/ > > > Testing > ------- > > make check done together with 60104 and 60103 > > > Thanks, > > Megha Sharma > >
