> On July 10, 2017, 11:14 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 747 (patched) > > <https://reviews.apache.org/r/60729/diff/1/?file=1771990#file1771990line747> > > > > The check `source == entry.root` is not correct. > > > > ``` > > root: the pathname of the directory in the filesystem > > which forms the root of this mount. > > ``` > > > > So if `/var/lib` is self bind mounted, the root might be something like > > `/mesos/.../.../`
Thank you, Jie! Good to know. Just read through out the kernel doc. It makes sense with that design. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60729/#review180074 ----------------------------------------------------------- On July 10, 2017, 11 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60729/ > ----------------------------------------------------------- > > (Updated July 10, 2017, 11 a.m.) > > > Review request for mesos, James DeFelice, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7770 > https://issues.apache.org/jira/browse/MESOS-7770 > > > Repository: mesos > > > Description > ------- > > This is the fix for MESOS-7770. Basically, if a persistent volume > and a host volume are both specified and the source path of the > host volume is the same as the container path of the persistent > volume, then the persistent volume will be skipped and is not > mounted correctly. We should precisely check the mount table > to determine whether the persistent volume is mounted or not. > If not mounted, make sure we do mount the persistent volume. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 69804eec61467ae0fd95dfdf53a08875e27a0bca > > > Diff: https://reviews.apache.org/r/60729/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
