----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60712/#review180332 -----------------------------------------------------------
src/common/http.hpp Lines 227 (patched) <https://reviews.apache.org/r/60712/#comment255442> s/Filtering/Filters/ src/common/http.cpp Lines 1190 (patched) <https://reviews.apache.org/r/60712/#comment255456> I think that testing for strict equality here will not work, since the `ContainerID` we are testing against may have the `parent` field set. This would come out in the test if we launched a task group (since those containers would have a parent), but since we aren't launching nested containers the test still passes. Instead, we should probably check that `containerId->value() == _containerId.value()` - Greg Mann On July 7, 2017, 11:47 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60712/ > ----------------------------------------------------------- > > (Updated July 7, 2017, 11:47 p.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-7630 > https://issues.apache.org/jira/browse/MESOS-7630 > > > Repository: mesos > > > Description > ------- > > Added filtering support for '/slave/containers' endpoint. > > Add query parameter support for '/slave/containers' endpoint. > To get the information about a specific container, you can specify > the container_id. The request would look like > '/slave/containers?container_id=[container id]'. > > When no container id is specified, it will return the information > about all containers. > > > Diffs > ----- > > src/common/http.hpp b7e4a8adcbcaa3a962af795c67694a35161b6c1a > src/common/http.cpp fdb591eccf273260902f3f695cf431f72ee3d817 > src/slave/http.hpp ad412d4e2fde13a7afa3563c611ef50b11829cac > src/slave/http.cpp 700871e1502a65b0bb1fc31219e09219dbdb5340 > src/tests/slave_tests.cpp 8a69cc2ede0b2f17a31986e9142aa2081691eb5e > > > Diff: https://reviews.apache.org/r/60712/diff/2/ > > > Testing > ------- > > Passed 'make check -j48' > Passed 'GLOG_v=1 ./bin/mesos-test.sh > --gtest_filter=SlaveTest.ContainersEndpoint --gtest_repeat=1000 > --gtest_break_on_failure' > > > Thanks, > > Quinn Leng > >
