> On July 12, 2017, 2:53 p.m., Qian Zhang wrote: > > src/linux/routing/diagnosis/diagnosis.cpp > > Line 77 (original), 78 (patched) > > <https://reviews.apache.org/r/60491/diff/3/?file=1774054#file1774054line78> > > > > Mind to explain a bit about why making this change? > > And with this change, I think you do not need to explicitly call the > > constructor of `Info` anymore.
I was near the code and I thought it could be improved by using `emplace_back`. Good point to remove unnecessary constructor. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60491/#review180287 ----------------------------------------------------------- On June 28, 2017, 7:44 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60491/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 7:44 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Capture the socket inode in the diagnosis Info when we use netlink > to enumerate the open sockets. This can be used to indentify which > process(es) have the socket open. > > > Diffs > ----- > > src/linux/routing/diagnosis/diagnosis.hpp > 7722fd2843614c3869cc6c3d06bc4c82ed282381 > src/linux/routing/diagnosis/diagnosis.cpp > aa2d020fc009040410ef557d10d386d04d71d16e > > > Diff: https://reviews.apache.org/r/60491/diff/3/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
