> On July 12, 2017, 1:47 a.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp > > Line 108 (original), 97 (patched) > > <https://reviews.apache.org/r/53479/diff/4/?file=1774290#file1774290line110> > > > > Why does this become public?
Fixed, moved to private. > On July 12, 2017, 1:47 a.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp > > Line 111 (original), 100 (patched) > > <https://reviews.apache.org/r/53479/diff/4/?file=1774290#file1774290line113> > > > > Can this be const? Can't `discard` a const. > On July 12, 2017, 1:47 a.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp > > Line 112 (original), 101 (patched) > > <https://reviews.apache.org/r/53479/diff/4/?file=1774290#file1774290line114> > > > > Do we need to pass this in? Initialized instead. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180261 ----------------------------------------------------------- On July 13, 2017, 9:48 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53479/ > ----------------------------------------------------------- > > (Updated July 13, 2017, 9:48 p.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Bugs: MESOS-6549 > https://issues.apache.org/jira/browse/MESOS-6549 > > > Repository: mesos > > > Description > ------- > > - Previously, rmdir operations were serialized > through the garbage collector. Expensive removal > events had the potential to delay task launch. > - MESOS-6549 > > > Diffs > ----- > > src/slave/gc.hpp 5ea82456cffa374203371f227b6f0ee00296553e > src/slave/gc.cpp 961f547793984449ea113d9664b12b5033638c58 > > > Diff: https://reviews.apache.org/r/53479/diff/6/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="GarbageCollector*" --gtest_repeat=100 > --gtest_break_on_failure` > > > Thanks, > > Jacob Janco > >
