----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60846/#review180564 -----------------------------------------------------------
Patch looks great! Reviews applied: [60846] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On July 14, 2017, 5:37 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60846/ > ----------------------------------------------------------- > > (Updated July 14, 2017, 5:37 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7777 > https://issues.apache.org/jira/browse/MESOS-7777 > > > Repository: mesos > > > Description > ------- > > This patch skips all failures returned from `Docker::rm` due to "failed > to remove root filesystem" during agent recovery, then schedule retries > with an exponential backoff, and go ahead to unmount the persistent > volumes for all Docker containers. > > The unit test `DockerContainerizerTest.ROOT_DOCKER_RecoverWithRmFails` > mocks `Docker::rm` to return 4 failures before actually perform > `docker rm` to test if the exponential backoff works correctly. > > > Diffs > ----- > > src/docker/docker.cpp 8ca0c68836ea5d1a1186e79942f6daccf6c6da46 > src/slave/constants.hpp 435c37e28987119c4ef43c9dad61ac052020acd8 > src/slave/containerizer/docker.cpp 5cd3b6d95ff78fb114a06d49122b7161a6688646 > src/slave/flags.hpp 858876fe86cc50cb3655b06071db6450916cb814 > src/slave/flags.cpp 74df647cc4f1161d061f0349011ce070db3a9789 > src/tests/containerizer/docker_containerizer_tests.cpp > 1e85a79f812399270575ea4a64db10e72f40e648 > src/tests/mock_docker.hpp 59873646be494c8fe6aebf5ede595d77e3ac4cae > src/tests/mock_docker.cpp 0ed63862f5c07935f088282157979eafdc814084 > > > Diff: https://reviews.apache.org/r/60846/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
