----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60887/ -----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7777 https://issues.apache.org/jira/browse/MESOS-7777 Repository: mesos Description ------- This patch makes `Docker::stop()` and `Docker::rm()` to explicit calls during agent recovery (which is the only place using this coupling). This decoupling avoids a `lambda::bind()` in `Docker::stop()` and thus enables us to mock `Docker::rm()` in `MockDocker`. Diffs ----- src/docker/docker.hpp 5593cb635e073334c6c2566be3d803cd7febb1c3 src/docker/docker.cpp 8081c0203bf62cf62aa3b93d745f0e829ad65509 src/slave/containerizer/docker.cpp 2fe92272d7ac6d916371c55affe24598255f10eb src/tests/containerizer/docker_containerizer_tests.cpp 1e85a79f812399270575ea4a64db10e72f40e648 src/tests/mock_docker.hpp 59873646be494c8fe6aebf5ede595d77e3ac4cae src/tests/mock_docker.cpp 0ed63862f5c07935f088282157979eafdc814084 Diff: https://reviews.apache.org/r/60887/diff/1/ Testing ------- sudo make check Thanks, Chun-Hung Hsiao