----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60831/#review180623 -----------------------------------------------------------
Fix it, then Ship it! Looks good, it would be nice to tease out the `string` -> `char*,size_t` change before you commit, since it seems independent. 3rdparty/libprocess/src/process.cpp Line 455 (original), 455 (patched) <https://reviews.apache.org/r/60831/#comment255822> Why did you decide to take `Message` here instead of `Message&&`? It seems a little odd that both `send` and `send_connect` took a pointer but now they've diverged in signature? 3rdparty/libprocess/src/process.cpp Lines 3809-3814 (original), 3807-3812 (patched) <https://reviews.apache.org/r/60831/#comment255824> Interesting, I didn't know this delegate concept existed, looks unused from my search of the code. - Benjamin Mahler On July 15, 2017, 12:13 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60831/ > ----------------------------------------------------------- > > (Updated July 15, 2017, 12:13 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7798 > https://issues.apache.org/jira/browse/MESOS-7798 > > > Repository: mesos > > > Description > ------- > > Removed extra/unnecessary allocations of Message. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > 8afe6266eb0dc5a17af35d79efb6bfdf9e6a0ee9 > 3rdparty/libprocess/include/process/gmock.hpp > e9af943b39436f365fe687301febb5c7fbefffc4 > 3rdparty/libprocess/include/process/protobuf.hpp > ba6e6d6504250a2609b336f3e9854cfbe5da52ec > 3rdparty/libprocess/src/encoder.hpp > ea629d72a68e093343562db1ef7e5d00c723f03b > 3rdparty/libprocess/src/process.cpp > 7ce6d2b13baa68906e091a95c0dd58ee1ca2bc7d > 3rdparty/libprocess/src/tests/process_tests.cpp > 38d787a083a5eb31e922d283f4b4bed2bd62eb0a > 3rdparty/libprocess/src/tests/test_linkee.cpp > 77df385d3388788658fa40d033816e1fbb8d8f2c > > > Diff: https://reviews.apache.org/r/60831/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
