----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60482/#review180697 -----------------------------------------------------------
Ship it! Going to add some more comments and whitespace before committing. cmake/CompilationConfigure.cmake Lines 346 (patched) <https://reviews.apache.org/r/60482/#comment255921> I'm going to add an extra comment above this section. cmake/CompilationConfigure.cmake Lines 347-348 (original), 367-368 (patched) <https://reviews.apache.org/r/60482/#comment255922> This comment should be updated to reflect the doubling in output. - Joseph Wu On June 27, 2017, 2:19 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60482/ > ----------------------------------------------------------- > > (Updated June 27, 2017, 2:19 p.m.) > > > Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, > Joseph Wu, and Li Li. > > > Bugs: MESOS-7173 > https://issues.apache.org/jira/browse/MESOS-7173 > > > Repository: mesos > > > Description > ------- > > This resolves MESOS-7173. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 3fa2e2f3b51a7a8dfe05085298f240019ff7b9c4 > src/common/build_config.hpp.in 174d8aaba850d99ceeea965cd5faf0624c5051d6 > > > Diff: https://reviews.apache.org/r/60482/diff/1/ > > > Testing > ------- > > Built `mesos-agent` with CMake on Linux and started it with `GLOG_v=3`: > > ``` > I0627 14:13:00.300671 75141 main.cpp:335] Git SHA: > ed1c00e9b12dbdead54f3630188db8c510654075 > ``` > > It appears to be working. > > > Thanks, > > Andrew Schwartzmeyer > >
