----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56611/#review180843 -----------------------------------------------------------
src/tests/containerizer/perf_tests.cpp Line 133 (original), 137-138 (patched) <https://reviews.apache.org/r/56611/#comment256140> Had a question about this comment when reviewing [r/60397](https://reviews.apache.org/r/60397/), this seems to imply the stub returns a non-zero exit status when run with `--version`? Is that true? It would be great to make that explicit in the comment: ``` // Note that on some systems, perf is a stub that asks you to // install the right packages and returns a non-zero exit status. ``` - Benjamin Mahler On Feb. 28, 2017, 5:43 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56611/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 5:43 a.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-6982 > https://issues.apache.org/jira/browse/MESOS-6982 > > > Repository: mesos > > > Description > ------- > > Relax perf version check for Arch Linux. > > > Diffs > ----- > > src/linux/perf.hpp 9c4330b6086abb18f036222260fe89a6fb01d8ed > src/linux/perf.cpp 3141e5ee9eee78e974625791f362dc345c682ebb > src/tests/containerizer/perf_tests.cpp > d536ecc5cb24787bc3487efb146573cd4f3ded43 > > > Diff: https://reviews.apache.org/r/56611/diff/4/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
