----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60822/#review180844 -----------------------------------------------------------
Could you update the Summary so that the endpoint paths are consistent? i.e., '/containers' instead of '/slave/containers' src/slave/http.cpp Lines 2043-2044 (original), 2043-2044 (patched) <https://reviews.apache.org/r/60822/#comment256145> Let's break before the capture list: ``` return authorizeContainer.then(defer(slave->self(), [this](const Owned<AuthorizationAcceptor>& authorizeContainer) { ``` src/slave/http.cpp Line 2090 (original), 2088 (patched) <https://reviews.apache.org/r/60822/#comment256143> Indented one space too far. src/slave/http.cpp Line 2130 (original), 2126 (patched) <https://reviews.apache.org/r/60822/#comment256141> Indent this line one more space. - Greg Mann On July 18, 2017, 6:24 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60822/ > ----------------------------------------------------------- > > (Updated July 18, 2017, 6:24 p.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-7630 > https://issues.apache.org/jira/browse/MESOS-7630 > > > Repository: mesos > > > Description > ------- > > Added query parameter support for the '/master/slaves', > '/master/frameworks' and '/slave/containers' endpoints. > > This allows slaves, frameworks and containers to be queried > by ID. > > If no ID is specified, all records are returned, consistent > with current behavior. > > > Diffs > ----- > > src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 > src/slave/http.hpp ad412d4e2fde13a7afa3563c611ef50b11829cac > src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 > > > Diff: https://reviews.apache.org/r/60822/diff/5/ > > > Testing > ------- > > Passed 'make check -j48' > > > Thanks, > > Quinn Leng > >
