> On July 19, 2017, 9:07 p.m., Jie Yu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 836 (patched) > > <https://reviews.apache.org/r/60984/diff/1/?file=1780076#file1780076line836> > > > > why my name on it?
Because your name is also here: https://github.com/apache/mesos/blob/72752fc6deb8ebcbfbd5448dc599ef3774339d31/src/slave/containerizer/mesos/io/switchboard.cpp#L535-L540 - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60984/#review180976 ----------------------------------------------------------- On July 19, 2017, 9:03 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60984/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 9:03 p.m.) > > > Review request for mesos, Avinash sridharan, Jie Yu, and Till Toenshoff. > > > Bugs: MESOS-7796 > https://issues.apache.org/jira/browse/MESOS-7796 > > > Repository: mesos > > > Description > ------- > > This patch updates the containerizer to manually set the `LIBPROCESS_IP` > environment variable to `127.0.0.1` when launching the fetcher POSIX > process. > > This environment variable is needed so that libprocess can be > initialized without depending on an external environment. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 6a664e0657a19d27afac98fd5298d6a18aabe43f > > > Diff: https://reviews.apache.org/r/60984/diff/1/ > > > Testing > ------- > > `make check` > > I also started tasks with URIs using DC/OS + Marathon on AWS clusters on > which it is not possible to resolve localhost. The tasks failed without this > patch, but they succeeded after having applied it. > > > Thanks, > > Gastón Kleiman > >
