> On July 18, 2017, 6:32 p.m., James Peach wrote: > > src/tests/slave_tests.cpp > > Lines 3440 (patched) > > <https://reviews.apache.org/r/60898/diff/2/?file=1778627#file1778627line3440> > > > > Is there a way you can set an expectation that a registry operation is > > not made? > > Jiang Yan Xu wrote: > This is it (a few lines above): > > ``` > // There should be no registrar operation across both agent termination > // and reregistration. > EXPECT_CALL(*master.get()->registrar.get(), apply(_)) > .Times(0); > ```
It's a few line apart because I am also asserting that no registry operation happened prior to master failover that transitions the agent to unreachable in the first place. I can add a comment about this near the end of the test though! - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60898/#review180894 ----------------------------------------------------------- On July 16, 2017, 11:29 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60898/ > ----------------------------------------------------------- > > (Updated July 16, 2017, 11:29 a.m.) > > > Review request for mesos, James Peach and Neil Conway. > > > Bugs: MESOS-7711 > https://issues.apache.org/jira/browse/MESOS-7711 > > > Repository: mesos > > > Description > ------- > > These new tests are specifically for verifying whether the registrar > is involved when an agent reregisters, depending on whether it has > been marked unreachable. > > > Diffs > ----- > > src/tests/slave_tests.cpp 053a14d1ea920058563173de7e0fa644fdbd8d96 > > > Diff: https://reviews.apache.org/r/60898/diff/2/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
