> On July 22, 2017, 10:37 a.m., Armand Grillet wrote:
> > As you add one assertion in slave_tests.cpp, you could also improve the
> > code style of the line 1364:
> >
> > Currently:
> > ```
> > EXPECT_EQ(
> > 1u,
> >
> > snapshot.values.count("slave/executor_directory_max_allowed_age_secs"))
> > ```
> >
> > Should be (to be consistent with master_tests.cpp):
> > ```
> > EXPECT_EQ(1u, snapshot.values.count(
> > "slave/executor_directory_max_allowed_age_secs"));
> > ```
The code style issue mentionned above is resolved in /r/61033, no need to
change this patch.
- Armand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61031/#review181172
-----------------------------------------------------------
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61031/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166
> src/tests/metrics_tests.cpp a4d0e3128c661b9ca5c63994cc3b9e498cce3af7
> src/tests/slave_tests.cpp e1cc96dbb279aea998b99779ee1b55e96fee4e41
>
>
> Diff: https://reviews.apache.org/r/61031/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61034/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
