----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60928/#review181243 -----------------------------------------------------------
Fix it, then Ship it! src/common/protobuf_utils.cpp Lines 821 (patched) <https://reviews.apache.org/r/60928/#comment256753> Why not save the `Framework*` instead i.e., the result of `mutable_framework()` for readability? src/common/protobuf_utils.cpp Lines 826 (patched) <https://reviews.apache.org/r/60928/#comment256754> new line. we typically leave a newline after multi line statements. Might not be needed post my earlier comment. src/common/protobuf_utils.cpp Lines 830-838 (patched) <https://reviews.apache.org/r/60928/#comment256755> Ditto (new lines) - Anand Mazumdar On July 19, 2017, 6:47 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60928/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 6:47 p.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, Vinod Kone, and Zhitao > Li. > > > Bugs: MESOS-6101 > https://issues.apache.org/jira/browse/MESOS-6101 > > > Repository: mesos > > > Description > ------- > > Added event 'FRAMEWORK_ADDED' for master's v1 streaming operator API. > It will be generated when the framework registers for the first time. > > > Diffs > ----- > > include/mesos/master/master.proto 7a722a6deac484f28a85f63fd68ef49cb6a47606 > include/mesos/v1/master/master.proto > cf88ea64fa08e4bdcf685de4def28d374eb32fdf > src/common/protobuf_utils.hpp 2156f6d158bfee16d29aa3531bdd156af581df01 > src/common/protobuf_utils.cpp 4e5ab02c90ad8490efbcc471f7fd7c48be0c4678 > src/master/master.cpp d895154c00eef17511c46ddd0b75922f952707eb > > > Diff: https://reviews.apache.org/r/60928/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Quinn Leng > >
