----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60930/#review181252 -----------------------------------------------------------
include/mesos/master/master.proto Lines 530 (patched) <https://reviews.apache.org/r/60930/#comment256776> How about: ```cpp // Forwarded by the master when a framework is removed. This can happen // when a framework is explicitly teardown by the operator or if it fails // to re-register with the master upon a disconnection (network error) or // master failover within the failover timeout. ``` include/mesos/v1/master/master.proto Lines 534 (patched) <https://reviews.apache.org/r/60930/#comment256777> hmm, should we send the `FrameworkInfo` here? IIRC, The reason we sent the `AgentID` for the agent removed event was that we only store the `AgentID` in the registry; so the `AgentInfo` is not available to us upon a failover. But, it seems like we already have `FrameworkInfo` available here. - Anand Mazumdar On July 18, 2017, 12:23 a.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60930/ > ----------------------------------------------------------- > > (Updated July 18, 2017, 12:23 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li. > > > Bugs: MESOS-6101 > https://issues.apache.org/jira/browse/MESOS-6101 > > > Repository: mesos > > > Description > ------- > > Added 'FRAMEWORK_REMOVED' event for master streaming api. > > > Diffs > ----- > > include/mesos/master/master.proto 7a722a6deac484f28a85f63fd68ef49cb6a47606 > include/mesos/v1/master/master.proto > cf88ea64fa08e4bdcf685de4def28d374eb32fdf > src/common/protobuf_utils.hpp 2156f6d158bfee16d29aa3531bdd156af581df01 > src/common/protobuf_utils.cpp 4e5ab02c90ad8490efbcc471f7fd7c48be0c4678 > src/master/master.cpp d895154c00eef17511c46ddd0b75922f952707eb > > > Diff: https://reviews.apache.org/r/60930/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Quinn Leng > >
