----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61094/#review181291 -----------------------------------------------------------
Ship it! src/examples/long_lived_framework.cpp Lines 109-111 (original), 109-115 (patched) <https://reviews.apache.org/r/61094/#comment256820> Hm... This lambda copies the (not-yet-fully-constructed) `this` reference and then uses the `.framework` field. Even though the ordering of initialization is guaranteed, this still seems odd. Perhaps the lambda could copy the `_framework` argument instead. - Joseph Wu On July 24, 2017, 4:28 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61094/ > ----------------------------------------------------------- > > (Updated July 24, 2017, 4:28 p.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > With multi-role support, resources have an explicit notion of > an allocation role. The allocation role is used in the `contains` check > for example. The task/executor resources that the long-lived-framework > uses therefore need to be updated such that the check works correctly. > > > Diffs > ----- > > src/examples/long_lived_framework.cpp > bfc71c5e98b6403fc9548d857d89863871655991 > > > Diff: https://reviews.apache.org/r/61094/diff/1/ > > > Testing > ------- > > Manually observed that the `long-lived-framework` successfully launches tasks. > > > Thanks, > > Michael Park > >
