----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61028/#review181375 -----------------------------------------------------------
src/master/metrics.hpp Lines 142 (patched) <https://reviews.apache.org/r/61028/#comment256914> These are not "messages" but "Calls" to the operator API; so they need to be named differently. There was a discussion earlier with @zhitao and @anand on the naming scheme; don't remember where we ended up; worthing pinging them. - Vinod Kone On July 24, 2017, 1:34 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61028/ > ----------------------------------------------------------- > > (Updated July 24, 2017, 1:34 p.m.) > > > Review request for mesos, Armand Grillet and Vinod Kone. > > > Bugs: MESOS-7747 > https://issues.apache.org/jira/browse/MESOS-7747 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32 > src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491 > src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f > src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166 > > > Diff: https://reviews.apache.org/r/61028/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/61034/ > > > Thanks, > > Alexander Rukletsov > >
