> On July 25, 2017, 10:06 p.m., Vinod Kone wrote: > > src/master/metrics.cpp > > Lines 223 (patched) > > <https://reviews.apache.org/r/61032/diff/1/?file=1780700#file1780700line223> > > > > Ideally our tests should've caught this :( Can you please update the > > metrics test to verify this metric? > > > > Also, please write a meaningful description that explains the issue and > > the fix; it's not at all clear from the summary.
I see that you fixed that in the next review; would be nice if you indicated it in the review description or testing done to give me a hint. Alternatively, I would've included the test update for this particular metric in this patch. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61032/#review181392 ----------------------------------------------------------- On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61032/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 2:32 p.m.) > > > Review request for mesos, Armand Grillet and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f > > > Diff: https://reviews.apache.org/r/61032/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/61034/ > > > Thanks, > > Alexander Rukletsov > >
